Fix unexpected fallbacks to full index by adding FalseClass and Time to the SafeMarshal list #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed this patch resolves the issue for us with this config: source 'https://rubygems.org'
source 'https://packagecloud.io/cinc-project/stable' do
gem 'chef', '~> 17.10.0'
gem 'chef-cli', '~> 5.6.1'
gem 'chef-utils'
gem 'mixlib-versioning'
end |
segiddins
approved these changes
May 5, 2023
| it "loads Gem::Specification" do | ||
| gem_spec = Gem::Specification.new("name", "3.7.2") | ||
| gem_spec = Gem::Specification.new do |s| |
There was a problem hiding this comment.
nit: this doesn't test false ?
|
👍 @indirect Thanks! |
deivid-rodriguez
changed the title
deivid-rodriguez
pushed a commit
that referenced
this pull request
May 9, 2023
add FalseClass and Time to the SafeMarshal list (cherry picked from commit 3593ade)
|
@deivid-rodriguez Do you think you could release RubyGems 3.4.13 to address this? It seems our |
|
Thanks! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
May 9, 2023
add FalseClass and Time to the SafeMarshal list (cherry picked from commit 3593ade)
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6614, maybe