Make LockfileParser usable with just a lockfile
#6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
LockfileParserLockfileParser usable with just a lockfile
duckinator
approved these changes
May 30, 2023
It's the only part that needs "root folder resultion" to figure out the folder for the cache, but it's only needed for some things, so run that logic lazily when needed.
deivid-rodriguez
force-pushed
the
delay-cache-access
branch
from
0af32d3
to
c7b9eae
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 8, 2023
Make `LockfileParser` usable with just a lockfile (cherry picked from commit fcad49a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I had this commit on an old WIP branch, and I think it may resolve #6671.
What is your fix for the problem, implemented in this PR?
Cache accessing in
LockfileParseris the only part that needs "root folder resolution" to figure out the folder for the cache, but it's only needed for some things, so run that logic lazily when needed.Make sure the following tasks are checked