-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gemfile.5
: Code format the default glob to escape Markdown
#6790
gemfile.5
: Code format the default glob to escape Markdown
#6790
Conversation
For consistency, I chose code format over plaintext escaping.
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ParadoxV5 Would you be able to run |
Not quite… I just patched the file on the GitHub web editor 😁. I’ll clone my fork locally rq. |
Co-Authored-By: David Rodríguez <2887858+deivid-rodriguez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ParadoxV5, thank you!
`gemfile.5`: Code format the default glob to escape Markdown (cherry picked from commit 0837d16)
What was the end-user or developer problem that led to this PR?
The default glob as rendered (
{,,/*}.gemspec
) doesn’t make sense.What is your fix for the problem, implemented in this PR?
Quote the default glob in an inline code rather than double-quotes so the
*
s don’t and will never leak out as Markdown for emphasis.Make sure the following tasks are checked
Write tests for features and bug fixes