-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid printing "Using ..." messages when version has not changed #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
Avoid printing using messages when version has not changed
Avoid printing "Using ..." messages when version has not changed
Jul 7, 2023
deivid-rodriguez
force-pushed
the
suppress_install_using_messages
branch
from
July 7, 2023 10:05
9caa4b3
to
9635a2f
Compare
simi
approved these changes
Jul 9, 2023
deivid-rodriguez
added a commit
that referenced
this pull request
Jul 12, 2023
Avoid printing "Using ..." messages when version has not changed (cherry picked from commit 20e6da4)
4 tasks
Thank you! ❤️ |
No problem! |
Fryguy
added a commit
to Fryguy/bundler-inject
that referenced
this pull request
Jul 27, 2023
Bundler 2.4.17 removed the "Using" statements in rubygems/rubygems#6804 which were relied upon by these specs.
mike-burns
added a commit
to thoughtbot/factory_bot_rails
that referenced
this pull request
Sep 1, 2023
The latest release of Bundler [removed] the "Using " lines from the output unless `--verbose` is passed. Ruby 3 ships with its own Bundler, which still has that line, but Ruby 2.7 does not, so we install the latest on CI. This is causing those tests to fail. [removed]: rubygems/rubygems#6804
mike-burns
added a commit
to thoughtbot/factory_bot_rails
that referenced
this pull request
Sep 1, 2023
The latest release of Bundler [removed] the "Using " lines from the output unless `--verbose` is passed. Ruby 3 ships with its own Bundler, which still has that line, but Ruby 2.7 does not, so we install the latest on CI. This is causing those tests to fail. [removed]: rubygems/rubygems#6804
Is there an ENV to enable the I fail to find anything suitable on https://bundler.io/v2.5/man/bundle-config.1.html |
Maybe |
Yes 😅 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Current default output is a bit too verbose.
What is your fix for the problem, implemented in this PR?
Avoid printing using messages when version has not changed.
Closes #6796.
Make sure the following tasks are checked