Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce bundle config set version feature to choose the version of Bundler that should be used and potentially disable using the lockfile version by setting it to system #6817

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jul 12, 2023

What was the end-user or developer problem that led to this PR?

Fixes #6613
Ref #6808

What is your fix for the problem, implemented in this PR?

I introduced bundle config --local set version global for disabling to auto-install locked version of Bundler. And I also introduced bundle config --local set version 2.4.0 for specifying to use version of Bundler.

Make sure the following tasks are checked

@hsbt hsbt force-pushed the allow-settings-prelease-bundler branch from 3e2cf1e to c431a1d Compare July 12, 2023 07:18
@hsbt hsbt merged commit e712345 into master Jul 13, 2023
92 checks passed
@hsbt hsbt deleted the allow-settings-prelease-bundler branch July 13, 2023 01:33
@deivid-rodriguez
Copy link
Member

I'm wondering if global and local are the best names here. It could get confusing in combination with --local and --global flags to bundle config. Perhaps lockfile instead of local, and default instead of global would be better?

Also I'd like to hear opinions from other maintainers before releasing this.

@hsbt
Copy link
Member Author

hsbt commented Jul 14, 2023

Perhaps lockfile instead of local

+1

And I prefer to use system instead of global.

@deivid-rodriguez
Copy link
Member

I also prefer system to both global and default 👍.

@hsbt hsbt mentioned this pull request Jul 19, 2023
4 tasks
@deivid-rodriguez deivid-rodriguez changed the title Introduce bundle config set version feature Introduce bundle config set version feature to choose the version of Bundler that should be used and potentially disable using the lockfile version by setting it to global Dec 7, 2023
@deivid-rodriguez deivid-rodriguez changed the title Introduce bundle config set version feature to choose the version of Bundler that should be used and potentially disable using the lockfile version by setting it to global Introduce bundle config set version feature to choose the version of Bundler that should be used and potentially disable using the lockfile version by setting it to system Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants