Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that bundle info takes a gem name #6875

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

manuraj17
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

Relates to #6212

bundle info [GEM] command's description didn't mention that only gem name is supported and adding the version was not required. The issue reported was around that confusion. One the suggestion in the discussion was to update the documentation which seemed like a fast thing to do for now.

What is your fix for the problem, implemented in this PR?

Update the man info.

Make sure the following tasks are checked

Screenshot

image

Note

This is my first PR in the repo, do let me know if I have missed any steps in the guidelines.
Also, do point out if I need to update in any other place other than this file.

@welcome
Copy link

welcome bot commented Aug 12, 2023

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Just had some minor comments on wording!

bundler/lib/bundler/man/bundle-info.1 Outdated Show resolved Hide resolved
@manuraj17 manuraj17 force-pushed the bundle-info-man-update branch 2 times, most recently from 9410169 to 22f0555 Compare August 15, 2023 06:55
@deivid-rodriguez deivid-rodriguez changed the title Update bundle info man description Clarify that bundle info takes a gem name Aug 17, 2023
@deivid-rodriguez
Copy link
Member

Rebased, squashed, and scheduled to auto-merge.

Thanks so much!

@deivid-rodriguez deivid-rodriguez merged commit d8dd8f8 into rubygems:master Aug 17, 2023
92 checks passed
deivid-rodriguez added a commit that referenced this pull request Aug 17, 2023
Clarify that `bundle info` takes a gem name

(cherry picked from commit d8dd8f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants