Resolve ruby version file relative to bundle root #6892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to rubygems#6742. This change makes it so that the version file is resolved relative to the Bundle root instead of the working directory. Why is this useful? If you run a commnad (eg `rails`) from the `app/` directory, your bundle would fail to load.
|
@deivid-rodriguez @martinemde I attempted to use |
deivid-rodriguez
approved these changes
Aug 18, 2023
martinemde
reviewed
Aug 18, 2023
|
|
||
| before do | ||
| allow(Bundler).to receive(:read_file).with(project_root.join("foo")).and_return("#{version}\n") | ||
| allow(Bundler).to receive(:root).and_return(Pathname.new("/path/to/project")) |
There was a problem hiding this comment.
Suggested change
| allow(Bundler).to receive(:root).and_return(Pathname.new("/path/to/project")) | |
| allow(Bundler).to receive(:root).and_return(project_root) |
Just a nitpick.
There was a problem hiding this comment.
Good point, Martin! Want me to open another PR to fix or you will just fix it on master?
There was a problem hiding this comment.
It's very tiny. Maybe it can get thrown into a follow up PR. #6895 wants to add .tool-versions support.
|
I'm ignoring my nitpick and getting this merged so that the feature works on master as intended. Thank you for testing and fixing this so quickly! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
Resolve ruby version file relative to bundle root (cherry picked from commit cabe7bb)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
Resolve ruby version file relative to bundle root (cherry picked from commit cabe7bb)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #6876. This change makes it so that the version file is resolved relative to the Bundle root instead of the working directory.
Why is this useful?
If you run a commnad (eg
rails) from theapp/directory, your bundle would fail to load.What was the end-user or developer problem that led to this PR?
Running
railsfrom a subdirectory in your project would fail because the version file would be resolved in the working directory...and therefore be not found.What is your fix for the problem, implemented in this PR?
Resolve from
Bundle.root.Make sure the following tasks are checked