Support ruby file: ".tool-versions" in Gemfile
#6898
Conversation
Add support for .tool-versions/ASDF by way of checking for a line starting with "ruby"
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
martinemde
changed the title
|
Can you add another test just like this one that returns a typical .tool-versions file with multiple different tool versions to make sure it works? |
|
@martinemde Thank you for guiding on this! |
Co-authored-by: Martin Emde <martinemde@users.noreply.github.com>
(rubygems/rubygems#6898) Supports .tool-versions (ASDF) by checking for a line starting with "ruby" before falling back to reading the entire file, as in .ruby-version. rubygems/rubygems@6c0a3e793a
deivid-rodriguez
changed the title
ruby file: ".tool-versions" in Gemfile
Supports .tool-versions (ASDF) by checking for a line starting with "ruby" before falling back to reading the entire file, as in .ruby-version. (cherry picked from commit 6c0a3e7)
Supports .tool-versions (ASDF) by checking for a line starting with "ruby" before falling back to reading the entire file, as in .ruby-version. (cherry picked from commit 6c0a3e7)
Add support for .tool-versions via simple detect a line begins with "ruby"
What was the end-user or developer problem that led to this PR?
Not supporting ASDF .tool-versions
What is your fix for the problem, implemented in this PR?
Discussed more in the relevant issue: #6895