Fix standalone install crashing when using legacy gemfiles with multiple global sources #6918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a legacy multi remote Gemfile depends transitively on a default gem, then in standalone mode we'd fail to fetch the proper version from the source that includes it, since we were adding it to `specs` (instead of `remote_specs`), which was already including the default version of the gem, and thus preventing the remote version from "overwriting that" and being added to the index. We should add it to the `remote_specs` index directly instead.
deivid-rodriguez
force-pushed
the
standalone-legacy-multi-global-sources
branch
from
a017207
to
05f4f9d
Compare
deivid-rodriguez
changed the title
martinemde
approved these changes
Aug 25, 2023
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…-sources Fix standalone install crashing when using legacy gemfiles with multiple global sources (cherry picked from commit 0413e7c)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…-sources Fix standalone install crashing when using legacy gemfiles with multiple global sources (cherry picked from commit 0413e7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If a legacy multi remote Gemfile depends transitively on a default gem,
bundle install --standalonewould crash.What is your fix for the problem, implemented in this PR?
If a legacy Gemfile with multiple global sources depends transitively on a default gem, then in standalone mode we'd fail to fetch the proper version from the source that includes it, since we were adding it to
specs(instead ofremote_specs), which was already including the default version of the gem, and thus preventing the remote version from "overwriting that" and being added to the index. We should add it to theremote_specsindex directly instead.Fixes #6273.
Make sure the following tasks are checked