Unify LockfileParser loading of SPECS section #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
commented
Sep 3, 2023
Ensure unrecognized SPECS types are ignored
martinemde
force-pushed
the
martinemde/lockfile-parser-refactor
branch
from
5aed150
to
5b33e91
Compare
segiddins
approved these changes
Sep 12, 2023
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…actor Unify LockfileParser loading of SPECS section (cherry picked from commit 46113c1)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…actor Unify LockfileParser loading of SPECS section (cherry picked from commit 46113c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Tiny refactor that was begging to be made.
What is your fix for the problem, implemented in this PR?
This was almost following a very common refactoring pattern, so I just took the last step.
Make sure the following tasks are checked