Avoid allocating empty hashes in Index #6962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the hashes have a default proc that returns a (new) empty hash, we can avoid allocating those empty hashes when we are only doing lookups. Test from running `bundle update --bundler` against a rails app I have lying around: ``` ==> memprof.after.txt <== Total allocated: 9.71 MB (68282 objects) Total retained: 4.87 MB (33791 objects) ==> memprof.before.txt <== Total allocated: 10.83 MB (100596 objects) Total retained: 5.02 MB (34721 objects) ```
martinemde
approved these changes
Sep 15, 2023
martinemde
force-pushed
the
segiddins/avoid-allocating-empty-hashes-in-index
branch
2 times, most recently
from
76da335
to
f1ec56c
Compare
martinemde
reviewed
Sep 15, 2023
bundler/lib/bundler/index.rb
Outdated
| @@ -170,31 +160,41 @@ def add_source(index) | |||
|
|
|||
| private | |||
|
|
|||
| def search_by_query(query) | |||
There was a problem hiding this comment.
There were no callers except the one here. Moved to private and changed to return nil when nothing found so calling code can more easily reduce array usage.
martinemde
force-pushed
the
segiddins/avoid-allocating-empty-hashes-in-index
branch
from
f1ec56c
to
e6f2146
Compare
segiddins
commented
Sep 15, 2023
martinemde
force-pushed
the
segiddins/avoid-allocating-empty-hashes-in-index
branch
7 times, most recently
from
21aed21
to
c8eb2f1
Compare
Remove the default nested hash in Index entirely Index#search_all now yields or returns enum since that's what caller needs.
martinemde
force-pushed
the
segiddins/avoid-allocating-empty-hashes-in-index
branch
from
c8eb2f1
to
c45ea3b
Compare
martinemde
deleted the
segiddins/avoid-allocating-empty-hashes-in-index
branch
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ty-hashes-in-index Avoid allocating empty hashes in Index (cherry picked from commit bf1c85d)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ty-hashes-in-index Avoid allocating empty hashes in Index (cherry picked from commit bf1c85d)
deivid-rodriguez
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Nov 8, 2023
* `Bundler::Fetcher#fetchers` was made private at rubygems/rubygems#6919. * `Bundler::Index#search_all` returns an enumerator since rubygems/rubygems#6962.
deivid-rodriguez
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Nov 9, 2023
* `Bundler::Fetcher#fetchers` was made private at rubygems/rubygems#6919. * `Bundler::Index#search_all` returns an enumerator since rubygems/rubygems#6962.
deivid-rodriguez
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Nov 15, 2023
* `Bundler::Fetcher#fetchers` was made private at rubygems/rubygems#6919. * `Bundler::Index#search_all` returns an enumerator since rubygems/rubygems#6962.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the hashes have a default proc that returns a (new) empty hash, we
can avoid allocating those empty hashes when we are only doing lookups.
Test from running
bundle update --bundleragainst a rails app I havelying around:
What was the end-user or developer problem that led to this PR?
What is your fix for the problem, implemented in this PR?
Make sure the following tasks are checked