Stop allocating the same settings keys repeatedly #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@technicalpickles you might like this one too :) |
Running `bundle update --bundler` on a rails app locally: ``` ==> memprof.after.txt <== Total allocated: 301.90 kB (3794 objects) Total retained: 73.24 kB (698 objects) ==> memprof.before.txt <== Total allocated: 14.47 MB (196378 objects) Total retained: 25.93 kB (202 objects) ``` So for a slight increase in retained memory (all keys are now retained), we go from about 200k allocations in the settings file to under 4k
segiddins
force-pushed
the
segiddins/stop-allocating-the-same-settings-keys-repeatedly
branch
from
750871e
to
e64debb
Compare
|
Nice work! |
indirect
deleted the
segiddins/stop-allocating-the-same-settings-keys-repeatedly
branch
Comment on lines
+547
to
+548
| when Symbol | ||
| key.name |
There was a problem hiding this comment.
Oh interesting! So this does not end up allocating any extra strings.
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
…same-settings-keys-repeatedly Stop allocating the same settings keys repeatedly (cherry picked from commit 92e666f)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
…same-settings-keys-repeatedly Stop allocating the same settings keys repeatedly (cherry picked from commit 92e666f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
bundle update --bundleron a rails app locally:So for a slight increase in retained memory (all keys are now retained),
we go from about 200k allocations in the settings file to under 4k
What was the end-user or developer problem that led to this PR?
What is your fix for the problem, implemented in this PR?
Make sure the following tasks are checked