Add Bundler::Plugin.loaded? helper #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful if your plugin introduces new methods to the DSL, so that Gemfiles can easily abort if the plugin hasn't loaded yet
ccutrer
force-pushed
the
bundler-plugin-loaded-p
branch
from
24cc54e
to
b733055
Compare
it was a performance improvement only, but it causes failures in unrelated tests
|
This is a very nice improvement, thank you for the PR! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Add Bundler::Plugin.loaded? helper (cherry picked from commit f8e87eb)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Add Bundler::Plugin.loaded? helper (cherry picked from commit f8e87eb)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Add Bundler::Plugin.loaded? helper (cherry picked from commit f8e87eb)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Add Bundler::Plugin.loaded? helper (cherry picked from commit f8e87eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I have a bundler plugin that adds to the bundler DSL. Right now users of the plugin must do something like
return unless defined?(...)to see if the plugin has loaded. A simpler, more direct helper was desired.What is your fix for the problem, implemented in this PR?
Add a Plugin.loaded? helper. Use it internally, also making Plugin.load_plugin idempotent (many plugins I've looked at have a tendency to call that method directly, and use a
unless defined?(...)guard.Make sure the following tasks are checked