Reduce allocations when installing gems with bundler #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
approved these changes
Sep 19, 2023
martinemde
force-pushed
the
segiddins/reduce-allocations-when-installing-gems-with-bundler
branch
from
17cc837
to
b36336a
Compare
segiddins
force-pushed
the
segiddins/reduce-allocations-when-installing-gems-with-bundler
branch
2 times, most recently
from
18ef2ff
to
25f4878
Compare
``` ==> memprof.after.txt <== Total allocated: 1.13 MB (2352 objects) Total retained: 10.08 kB (78 objects) ==> memprof.before.txt <== Total allocated: 46.27 MB (38439 objects) Total retained: 9.94 kB (75 objects) ``` Yes, we were allocating 45MB of arrays in `dependencies_installed?`, it was accidentally cubic.
deivid-rodriguez
force-pushed
the
segiddins/reduce-allocations-when-installing-gems-with-bundler
branch
from
25f4878
to
13ab874
Compare
segiddins
deleted the
segiddins/reduce-allocations-when-installing-gems-with-bundler
branch
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, we were allocating 45MB of arrays in
dependencies_installed?,it was accidentally cubic.
What was the end-user or developer problem that led to this PR?
What is your fix for the problem, implemented in this PR?
Make sure the following tasks are checked