Fix bundle lock --minor --update <dep> edge case
#6992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the latest allowed minor of `dep` adds a new dependency, that new dependency would be incorrectly resolved to the latest minor of the first major version.
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
…-added Fix `bundle lock --minor --update <dep>` edge case (cherry picked from commit 2749d12)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
…-added Fix `bundle lock --minor --update <dep>` edge case (cherry picked from commit 2749d12)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
…-added Fix `bundle lock --minor --update <dep>` edge case (cherry picked from commit 2749d12)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 16, 2023
…-added Fix `bundle lock --minor --update <dep>` edge case (cherry picked from commit 2749d12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When the latest allowed minor of
depadds a new dependency, that new dependency would be incorrectly resolved to the latest minor of the first major version.What is your fix for the problem, implemented in this PR?
The
--minorlogic should only be applied for dependencies that are already locked.Fixes #6952.
Make sure the following tasks are checked