Only remove bundler plugin gem when it's inside the cache

[ccutrer]

Fixes #6953

What was the end-user or developer problem that led to this PR?

A plugin installed with a local path (i.e. via #6960) would completely remove the external gem when you run bundle plugin uninstall.

What is your fix for the problem, implemented in this PR?

Ensure that any paths are within the plugin root before removing.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[ccutrer]

Can you retry the actions? It looks like they failed due to intermittent network issues trying to reach rubygems.org.

[deivid-rodriguez]

I retried but it still failed. Does the new spec run fine for you locally?

[ccutrer]

Yes, the new spec runs fine for me on Mac, Ruby 3.1. The failures in GitHub Actions are for specs completely unrelated to plugins.

[deivid-rodriguez]

I'm seeing this, which is the spec you added here, right?

       Invoking `/Users/runner/hostedtoolcache/Ruby/3.2.1/x64/bin/ruby -I/Users/runner/work/rubygems/rubygems/bundler/spec -r/Users/runner/work/rubygems/rubygems/bundler/spec/support/artifice/fail.rb -r/Users/runner/work/rubygems/rubygems/bundler/spec/support/hax.rb /Users/runner/work/rubygems/rubygems/bundler/tmp/1/gems/system/bin/bundle plugin install path_plugin --path /Users/runner/work/rubygems/rubygems/bundler/tmp/1/libs/path_plugin-1.0` failed with output:
       ----------------------------------------------------------------------
       Could not reach host index.rubygems.org. Check your network connection and try again.
       ----------------------------------------------------------------------
     # ./spec/support/helpers.rb:202:in `sys_exec'
     # ./spec/support/helpers.rb:121:in `bundle'
     # ./spec/plugins/uninstall_spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:102:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:102:in `block (3 levels) in <top (required)>'
     # ./spec/support/helpers.rb:357:in `block in with_gem_path_as'
     # ./spec/support/helpers.rb:371:in `without_env_side_effects'
     # ./spec/support/helpers.rb:352:in `with_gem_path_as'
     # ./spec/spec_helper.rb:101:in `block (2 levels) in <top (required)>'

Finished in 45 minutes 24 seconds (files took 1.67 seconds to load)
3411 examples, 1 failure, 16 pending

Failed examples:

rspec ./spec/plugins/uninstall_spec.rb:33 # bundler plugin uninstall doesn't wipe out path plugins

[ccutrer]

Oh man, I apologize. I was reading the output wrong. Yes, that's my new spec. I was seeing the gem generate index in the log and was thinking it was for a spec having to do with that (combined with scrolling too far past all the pending specs). I'll dig in. Probably an inadvertent network access.

[ccutrer]

Ohhhhhh.... that's why. The spec uses bundle install plugin <plugin> --path <path>, which doesn't exist yet. That's why I had this commit as part of #6960. So the path argument is ignored, and it's trying to find that plugin on Rubygems. If #6960 is merged first, I can rebase this one and then it will work.

[deivid-rodriguez]

Aaaah right, that makes sense!

[deivid-rodriguez]

Should we instead change the spec here to use plugin "my_plugin", path: "../my_plugin" in a Gemfile, like in the linked issue, so that this fix is not blocked on the addition of the --path flag to bundle plugin install?

[deivid-rodriguez]

Looks great, I'll try to merge & release this fix this week!