Avoid duplicates -rbundler/setup in RUBYOPT with Ruby preview

[intrip]

What was the end-user or developer problem that led to this PR?

When using a Ruby preview version the require path of bundler/setup is similar to -r/opt/ruby3.3.0-preview2/lib/ruby/3.3.0+0/bundler/setup. The special character + in the string makes the Regexp matching fail leading to the addition of duplicate require statements to RUBYOPT (e.g. server reloading).

Example:

>> RUBY_DESCRIPTION
=> "ruby 3.3.0preview2 (2023-09-14 master e50fcca9a7) [arm64-darwin22]"
>> ENV["RUBYOPT"]
=> "-r/Users/jacopobeschi/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/bundler-2.3.24/lib/bundler/setup"
>> Bundler::SharedHelpers.send(:set_rubyopt)
=> "-r/Users/jacopobeschi/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/bundler-2.3.24/lib/bundler/setup -r/Users/jacopobeschi/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/bundler-2.3.24/lib/bundler/setup"
>> ENV["RUBYOPT"]
=> "-r/Users/jacopobeschi/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/bundler-2.3.24/lib/bundler/setup -r/Users/jacopobeschi/.rbenv/versions/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/bundler-2.3.24/lib/bundler/setup"

What is your fix for the problem, implemented in this PR?

Escaping the characters in the string ensure a correct match with all the different Ruby versions.

Example:

>> s
=> "gems/3.3.0+0/gems/bundler-2.3.24/lib/bundler/setup"
>> /#{s}/.match?(s)
=> false
>> /#{Regexp.escape(s)}/.match?(s)
=> true

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

I think there are specs for this at bundler/spec/bundler/shared_helpers_spec.rb, could you add one to catch this issue?

[intrip]

I think there are specs for this at bundler/spec/bundler/shared_helpers_spec.rb, could you add one to catch this issue?

Of course! Added a test.

[intrip]

Just noticed the failure, will fix it

[deivid-rodriguez]

Thank you!

[deivid-rodriguez]

Super minor comment on the spec. Feel free to address it if you think it's a improvement!

[intrip]

I'm having trouble reproducing the failure locally because It's triggered only in some combination of the test matrix. I've added a stub which "should" help but I have zero knowledge of this codebase, so let's wait for CI 🤞😅.

[intrip]

@deivid-rodriguez CI is green now

[deivid-rodriguez]

Looks great, thank you!