Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include gemspec in ExtensionTask for native gem tasks #7015

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

mgmarlow
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

Original issue stated in oxidize-rb/rb-sys#249.

New gems created with --ext=rust do not include the native build tasks from rake-compiler.

What is your fix for the problem, implemented in this PR?

Pass the gemspec into the second argument to RbSys::ExtensionTask so the native gem tasks are available for Rake. Users can now run bundle exec rake native gem after generating a new Rust extension.

Make sure the following tasks are checked

@welcome
Copy link

welcome bot commented Sep 29, 2023

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

@hsbt hsbt merged commit 406dd6b into rubygems:master Oct 2, 2023
92 checks passed
deivid-rodriguez pushed a commit that referenced this pull request Oct 13, 2023
Include gemspec in ExtensionTask for native gem tasks

(cherry picked from commit 406dd6b)
deivid-rodriguez pushed a commit that referenced this pull request Oct 13, 2023
Include gemspec in ExtensionTask for native gem tasks

(cherry picked from commit 406dd6b)
deivid-rodriguez pushed a commit that referenced this pull request Oct 13, 2023
Include gemspec in ExtensionTask for native gem tasks

(cherry picked from commit 406dd6b)
deivid-rodriguez pushed a commit that referenced this pull request Oct 16, 2023
Include gemspec in ExtensionTask for native gem tasks

(cherry picked from commit 406dd6b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants