Support Ruby's preview version format (Ex: 3.3.0-preview2) in Gemfile #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
reviewed
Sep 30, 2023
deivid-rodriguez
approved these changes
Sep 30, 2023
There was a problem hiding this comment.
I believe this PR is the right solution.
Unfortunately RubyGems does not accept versions with the - character in them, so it uses something that looks similar.
In the RubyGems side, we do the same kind of trick by extracting the prerelease identifier from RUBY_DESCRIPTION, and putting it after RUBY_VERSION, so that
$ ruby -e 'puts Gem.ruby_version'
3.3.0.preview2
So we should make sure we do the same thing with the Ruby version in Gemfile to avoid this kind of mismatch.
simi
reviewed
Sep 30, 2023
harshalbhakta
force-pushed
the
ruby-preview-gemfile
branch
from
3337d9f
to
4409d30
Compare
harshalbhakta
force-pushed
the
ruby-preview-gemfile
branch
from
4409d30
to
4c1a051
Compare
simi
approved these changes
Oct 1, 2023
hsbt
approved these changes
Oct 2, 2023
|
Thanks for working on this. It bit me big time in heroku/docker-heroku-ruby-builder#34 |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
Support Ruby's preview version format (Ex: 3.3.0-preview2) in Gemfile (cherry picked from commit 337d463)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
Support Ruby's preview version format (Ex: 3.3.0-preview2) in Gemfile (cherry picked from commit 337d463)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
Support Ruby's preview version format (Ex: 3.3.0-preview2) in Gemfile (cherry picked from commit 337d463)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 16, 2023
Support Ruby's preview version format (Ex: 3.3.0-preview2) in Gemfile (cherry picked from commit 337d463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Fixes #7013
Support Ruby's preview versions in Gemfile.
What is your fix for the problem, implemented in this PR?
Replaced '-' with '.' before passing to
Gem::Requirement.parseto support preview version format (Ex: 3.3.0-preview2) in Gemfile.Make sure the following tasks are checked