Don't re-resolve with prereleases if unlocked gem has no prereleases #7021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
avoid-unnecessary-reresolves
branch
from
3ef70d6
to
d76dc70
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Don't re-resolve with prereleases if unlocked gem has no prereleases (cherry picked from commit 41870fb)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Don't re-resolve with prereleases if unlocked gem has no prereleases (cherry picked from commit 41870fb)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Don't re-resolve with prereleases if unlocked gem has no prereleases (cherry picked from commit 41870fb)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 16, 2023
Don't re-resolve with prereleases if unlocked gem has no prereleases (cherry picked from commit 41870fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I noticed that sometimes when we fail to resolve, we retry resolution claiming that we'll consider pre-releases for the gem that failed to resolve. However, if that gem has no prereleases, it will fail again in the exact same way since the set of gems considered is the same
What is your fix for the problem, implemented in this PR?
Only do this retry is there are really some extra prerelease gems that we will start considering the second time.
Make sure the following tasks are checked