Raise an error when adding a gem incompatible with some locked platform #7035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
multiplatform-resolve-fix
branch
from
666496a
to
b9e6c4b
Compare
deivid-rodriguez
force-pushed
the
multiplatform-resolve-fix
branch
2 times, most recently
from
7c93cf2
to
5d7f0df
Compare
deivid-rodriguez
force-pushed
the
multiplatform-resolve-fix
branch
from
5d7f0df
to
25304f3
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Raise an error when adding a gem incompatible with some locked platform (cherry picked from commit e6bd3cb)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Raise an error when adding a gem incompatible with some locked platform (cherry picked from commit e6bd3cb)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 13, 2023
Raise an error when adding a gem incompatible with some locked platform (cherry picked from commit e6bd3cb)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 16, 2023
Raise an error when adding a gem incompatible with some locked platform (cherry picked from commit e6bd3cb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
While working on #5700, I noticed that when locking multiple platforms, and adding a new dependency to the Gemfile that does not support some of the platforms, we may end up with a successful resolution, and a lockfile that's not really valid.
What is your fix for the problem, implemented in this PR?
My fix is to prevent this situation at the resolver level, and give a proper error about it.
Since there are existing lockfiles with this bug, which will no longer
bundle updatefine even on platforms where they are valid, I also made sure to detect invalid platforms like these and remove them before re-resolving, so that the lockfile continues to work in the platforms where it was valid.Make sure the following tasks are checked