Don't show bug report template when GEM_HOME has no writable bit #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, don't check that at all and proceed. If something fails to be written inside GEM_HOME, we'll eventually fail with a proper permissions error. In addition to that, the writable bit in GEM_HOME is not even reliable, because only the immediate parent is actually checked when writing. For example, ``` $ mkdir -p foo/bar $ chmod -w foo $ touch foo/bar/baz # writes without issue ```
deivid-rodriguez
force-pushed
the
bundler-permissions-crash
branch
from
f30454d
to
4bced7a
Compare
martinemde
approved these changes
Oct 27, 2023
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
Don't show bug report template when GEM_HOME has no writable bit (cherry picked from commit 15ee7fc)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
Don't show bug report template when GEM_HOME has no writable bit (cherry picked from commit 15ee7fc)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
Don't show bug report template when GEM_HOME has no writable bit (cherry picked from commit 15ee7fc)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
Don't show bug report template when GEM_HOME has no writable bit (cherry picked from commit 15ee7fc)
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Bug report template being displayed to users: #7111.
What is your fix for the problem, implemented in this PR?
My fix is to remove raising if GEM_HOME does not satisfy
File.writable?.Instead, don't check that at all and proceed.
If something fails to be written inside GEM_HOME, we'll eventually fail with a proper permissions error.
In addition to that, the writable bit in GEM_HOME is not even reliable, because only the immediate parent is actually checked when writing. For example,
Closes #7111.
Make sure the following tasks are checked