-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ruby 2.6 and 2.7 support #7116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great work!
bea7b82
to
de30db4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally 🙏
Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. I reviewed all the non-deleted files and everything looks good to me. I didn't manually inspect the deleted files, but they appear to entirely consist of tool/bundler/*26_gems.rb*
, .github/workflows/legacy-git.yml
, and over 1,300 cached network requests under vcr_cassettes
— and I don't think that should give us problems if CI passes for this. 🙂
Yeah! I was a bit disappointed that the work I did at #6208 never paid off, but it finally showed up to remind us to delete 1.3k files 😃 |
de30db4
to
4a2cbfd
Compare
4a2cbfd
to
d06544a
Compare
Let's do it! |
Mirroring the change to rubygems in rubygems/rubygems#7116
since 2.6 and 2.7 are EOL and bundler dropped their support by rubygems#7116.
…late since 2.6 and 2.7 are EOL and bundler dropped their support by rubygems/rubygems#7116. rubygems/rubygems@b562d9a822
``` $ ruby -v ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux] $ gem update --system Updating rubygems-update ERROR: Error installing rubygems-update: rubygems-update-3.5.6 requires Ruby version >= 3.0.0. The current ruby version is 2.7.8. $ ``` https://github.com/rubygems/rubygems/blob/master/CHANGELOG.md#350--2023-12-15 > Drop ruby 2.6 and 2.7 support. Pull request #7116 by deivid-rodriguez rubygems/rubygems#7116
What was the end-user or developer problem that led to this PR?
Time to move on. These are EOL.
What is your fix for the problem, implemented in this PR?
Delete all the things.
Make sure the following tasks are checked