Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify remembered flags deprecation message #7189

Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

This deprecation message recommends bundle config set --local, however bundle config is now local by default. It also quotes some values unnecessarily.

What is your fix for the problem, implemented in this PR?

Simplify the deprecation message.

Make sure the following tasks are checked

@deivid-rodriguez
Copy link
Member Author

The "risk" of this is that users may copy the deprecation message to an app still using a old Bundler version where bundle config was not local, so maybe not worth changing.

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to print messages that only apply to the running version of Bundler, but thank you for calling out that risk!

@deivid-rodriguez deivid-rodriguez merged commit f2abe08 into master Nov 24, 2023
66 checks passed
@deivid-rodriguez deivid-rodriguez deleted the simplify-remembered-flags-deprecation-message branch November 24, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants