-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use match? when regexp match data is unused #7263
Use match? when regexp match data is unused #7263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised Performance/RegexpMatch
does not catch this!
76d404b
to
09d259e
Compare
One of the methods ... moved, I think? Want to correct that here or just resolve the conflict? |
Yeah, the method was deleted at #7258, we'd want to apply the same patch, but here: Lines 107 to 116 in c09c923
|
Improved performance / reduced allocations
09d259e
to
b04726c
Compare
I resolved the conflict 👍. |
Improved performance / reduced allocations
What was the end-user or developer problem that led to this PR?
What is your fix for the problem, implemented in this PR?
Make sure the following tasks are checked