Fix ruby Gemfile DSL with file: parameter no longer working
#7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I understand the original issue now. Working on fix and test for that too. |
deivid-rodriguez
force-pushed
the
fix-ruby-dsl
branch
2 times, most recently
from
26f8ccf
to
d02c57c
Compare
deivid-rodriguez
changed the title
ruby Gemfile DSL with file: parameter no longer working
deivid-rodriguez
force-pushed
the
fix-ruby-dsl
branch
from
d02c57c
to
b2136e5
Compare
Co-authored-by: AndrewSwerlick <andrew.swerlick@gmail.com>
deivid-rodriguez
force-pushed
the
fix-ruby-dsl
branch
from
b2136e5
to
f6258e5
Compare
martinemde
approved these changes
Dec 15, 2023
|
Thanks for coming to the rescue @deivid-rodriguez! |
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 15, 2023
Fix `ruby` Gemfile DSL with `file:` parameter no longer working (cherry picked from commit 147fe3e)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The
rubyDSL is not working properly in Bundler 2.5.What is your fix for the problem, implemented in this PR?
Add the missing
attr_readerand cover the simple case and the one reported at #7219 with realworld specs.Fixes #7286.
Make sure the following tasks are checked