Fix incorrect lockfiles being generated in some situations #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix-incorrect-lockfile
branch
from
c28c7af
to
00976c6
Compare
deivid-rodriguez
force-pushed
the
fix-incorrect-lockfile
branch
from
00976c6
to
f985385
Compare
Before, every time we accessed a spec set with a name not present in the underlying hash, an entry with an empty set of specs was created for it. I think it's best to assume all keys in a spec set have actual keys, at least I was assuming that until I found about this.
deivid-rodriguez
force-pushed
the
fix-incorrect-lockfile
branch
from
f985385
to
b558baa
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 21, 2023
Fix incorrect lockfiles being generated in some situations (cherry picked from commit 10d74a3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since 5f24f06, Bundler will automatically complete the resolution it found with extra platforms that are also valid for the resolution that was initially found.
However, if one of the platform specific gems being added brings extra dependencies, the new resolution will never be invalid since we'll be missing the extra dependency.
What is your fix for the problem, implemented in this PR?
This PR fixes the issue by avoiding the addition of platforms and platform specific gems in the above situation.
Closes #7304.
Builds on top of #7306.
Make sure the following tasks are checked