Fix bundle update --bundler when latest version does not support current ruby
#7310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
bundle update --bundler when latest version does not support cu…bundle update --bundler when latest version does not support current ruby
|
@deivid-rodriguez maybe using artifice for specs would make it easier, since that doesn't care what the host is? |
deivid-rodriguez
force-pushed
the
fix-bundle-update-bundler
branch
3 times, most recently
from
e729d5e
to
fe4568f
Compare
segiddins
approved these changes
Dec 21, 2023
deivid-rodriguez
force-pushed
the
fix-bundle-update-bundler
branch
from
fe4568f
to
c5f4c91
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 21, 2023
Fix `bundle update --bundler` when latest version does not support current ruby (cherry picked from commit 28cc13a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
bundle update --bundleris also suffering from the issue of not being able to tell if the latest bundler supports the current ruby or not :(What is your fix for the problem, implemented in this PR?
My fix is to add the proper filtering so that the correct version is selected, however, that can't be magically propagated to the Bundler version users on old rubies are running, so the issue will keep showing up for users of old rubies that for some reason what to upgrade Bundler.
I didn't write tests because they are tricky due to the implementation hardcoding
rubygems.org. Once #5498 is fixed, it would become easier.Fixes #7308.
Make sure the following tasks are checked