Fix incorrect error when Gemfile overrides a gemspec development dependency #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit of a mess right now, just trying to make it a bit easier to parse.
…dency It should be only a warning.
deivid-rodriguez
force-pushed
the
fix-more-dev-deps-warnings
branch
from
a087e2c
to
48589e4
Compare
simi
approved these changes
Dec 21, 2023
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 22, 2023
Fix incorrect error when Gemfile overrides a gemspec development dependency (cherry picked from commit ae670d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We added a warning when gemspec development dependencies are being overridden, but it was incorrect in certain situations and causing a hard error.
What is your fix for the problem, implemented in this PR?
Properly account of the potential different parsing order between Gemfile and gemspec development dependencies.
Fixes #6014 (comment).
Make sure the following tasks are checked