Fix resolution when different platform specific gems have different dependencies #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix-multiplatform-resolution
branch
from
6feab10
to
1996ee8
Compare
If two platform specific variants have different dependencies, then resolution may fallback to the non platform specific variant. However, the platform specific variants that have the same dependencies as the non specific one can still be kept. Do a pass to complete those after resolution.
deivid-rodriguez
force-pushed
the
fix-multiplatform-resolution
branch
from
9c9920e
to
b60fdb3
Compare
|
I added a spec for this but turns out our own lockfile was suffering from this and caught the bug too! |
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 3, 2024
Fix resolution when different platform specific gems have different dependencies (cherry picked from commit 5246c0f)
AnyOldName3
added a commit
to openscenegraph/openscenegraph.io
that referenced
this pull request
Jan 3, 2024
The bug is fixed by rubygems/rubygems#7324 This is what the fixed version would have produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If two platform specific variants of the same gem version have different dependencies, our resolver may fallback to picking only the RUBY variant. However, some platform specific gems may still be compatible with the resolution.
What is your fix for the problem, implemented in this PR?
Do one pass after resolution completing platforms specific gems that may be compatible.
Fixes #7321.
Make sure the following tasks are checked