Fix ETag quoting regression in If-None-Match header of compact index request #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
martinemde/quote-etag-compact-index
branch
from
cc2ddee
to
559e89a
Compare
deivid-rodriguez
approved these changes
Jan 4, 2024
New laptop and my tests weren't working yet so I had to rely on CI 😬 I'll get these this morning. |
martinemde
force-pushed
the
martinemde/quote-etag-compact-index
branch
from
559e89a
to
e4f2531
Compare
martinemde
force-pushed
the
martinemde/quote-etag-compact-index
branch
from
e4f2531
to
d26bcd7
Compare
martinemde
changed the title
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 17, 2024
…index Fix ETag quoting regression in If-None-Match header of compact index request (cherry picked from commit e25fb48)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 17, 2024
…index Fix ETag quoting regression in If-None-Match header of compact index request (cherry picked from commit e25fb48)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 17, 2024
…index Fix ETag quoting regression in If-None-Match header of compact index request (cherry picked from commit e25fb48)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 17, 2024
…index Fix ETag quoting regression in If-None-Match header of compact index request (cherry picked from commit e25fb48)
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
HTTP spec requires that ETags in the If-None-Match header must be quoted. Requests to the rubygems.org index without quoted ETag are never matched for a 304 response, always falling back to a partial content request at best.
What is your fix for the problem, implemented in this PR?
Fix unintentional removal of quotes around the ETag in the compact index
If-None-Matchheader. Make sure that tests cover this requirement.I also changed a method name that was being shadowed by local variables to make the code a bit more clear.
Make sure the following tasks are checked