Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to underscores as underscores #7364

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Refer to underscores as underscores #7364

merged 1 commit into from
Jan 8, 2024

Conversation

avdi
Copy link
Contributor

@avdi avdi commented Jan 8, 2024

What was the end-user or developer problem that led to this PR?

Confusing documentation

Copy link

welcome bot commented Jan 8, 2024

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simi
Copy link
Member

simi commented Jan 8, 2024

I'll fix CI.

@simi simi disabled auto-merge January 8, 2024 20:39
@simi simi enabled auto-merge January 8, 2024 20:39
@simi simi merged commit 8ffa73d into rubygems:master Jan 8, 2024
82 checks passed
deivid-rodriguez pushed a commit that referenced this pull request Jan 17, 2024
Refer to underscores as underscores

(cherry picked from commit 8ffa73d)
deivid-rodriguez pushed a commit that referenced this pull request Jan 17, 2024
Refer to underscores as underscores

(cherry picked from commit 8ffa73d)
deivid-rodriguez pushed a commit that referenced this pull request Jan 17, 2024
Refer to underscores as underscores

(cherry picked from commit 8ffa73d)
deivid-rodriguez pushed a commit that referenced this pull request Jan 17, 2024
Refer to underscores as underscores

(cherry picked from commit 8ffa73d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants