Meta: Link for did meta plugin abstract class #6601 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good, but I'm not sure what's going on with the build failing in the CI. It failed in multiple attempts, and the error seems to be pretty generic: https://github.com/rucio/documentation/actions/runs/8436939278/job/23107408245?pr=302. I think it might be due to the line length. The line's total length after the change is 172 characters, and it might conflict with this rule: https://github.com/rucio/documentation/blob/main/tools/.mdl/mdlrc_style_long_lines.rb#L5 (although this rule should ignore URLs, according to this: https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md013---line-length - maybe it's that |
rdimaio
reviewed
Mar 26, 2024
voetberg
force-pushed
the
6601_metadata_plugin_link
branch
from
5a4ae63
to
f77c47e
Compare
voetberg
force-pushed
the
6601_metadata_plugin_link
branch
from
67c4fa4
to
f77c47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the link to the DID Meta abstract class