Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk list_files : Closes #5465 #5830

Merged
merged 2 commits into from Mar 19, 2024
Merged

Conversation

cserf
Copy link
Contributor

@cserf cserf commented Aug 24, 2022

This patch introduce a new bulk_list_files method that is useful for some workflows. The new methods takes a list of dids and return the list of associated files. Closes #5465

lib/rucio/api/did.py Outdated Show resolved Hide resolved
@cserf cserf force-pushed the patch-5465-Bulk_list_files branch from 023af07 to e1923ec Compare March 2, 2023 16:54
@bari12
Copy link
Member

bari12 commented May 5, 2023

LGTM
Two things:

  • Please squash it into one commit and follow naming according to contribution guide
  • One conflict, needs rebase

@bari12 bari12 removed the request for review from bziemons September 13, 2023 09:10
@cserf cserf force-pushed the patch-5465-Bulk_list_files branch 2 times, most recently from b58f362 to fc75b7d Compare September 14, 2023 13:05
@bari12 bari12 self-requested a review September 14, 2023 14:35
@cserf cserf force-pushed the patch-5465-Bulk_list_files branch 2 times, most recently from d2c0ce3 to f546db2 Compare September 15, 2023 12:30
@cserf cserf force-pushed the patch-5465-Bulk_list_files branch from f546db2 to c9a4fcb Compare March 6, 2024 13:09
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
lib/rucio/core/did.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rdimaio rdimaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as for core/did.py

lib/rucio/api/did.py Outdated Show resolved Hide resolved
lib/rucio/api/did.py Outdated Show resolved Hide resolved
lib/rucio/api/did.py Outdated Show resolved Hide resolved
lib/rucio/api/did.py Outdated Show resolved Hide resolved
lib/rucio/api/did.py Outdated Show resolved Hide resolved
lib/rucio/client/didclient.py Outdated Show resolved Hide resolved
lib/rucio/client/didclient.py Outdated Show resolved Hide resolved
@cserf cserf force-pushed the patch-5465-Bulk_list_files branch 3 times, most recently from 2060b93 to 2dd16f8 Compare March 8, 2024 10:02
@cserf cserf force-pushed the patch-5465-Bulk_list_files branch from 2dd16f8 to eaa59bd Compare March 8, 2024 12:43
@bari12 bari12 merged commit f549e3c into rucio:master Mar 19, 2024
44 checks passed
bari12 pushed a commit that referenced this pull request Mar 19, 2024
* Client : Introduce bulk_list_files method : Closes #5465

* Add/fix type annotation
voetberg pushed a commit to voetberg/rucio that referenced this pull request Apr 15, 2024
* Client : Introduce bulk_list_files method : Closes rucio#5465

* Add/fix type annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk list_files
4 participants