Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core & Internals: core/rule.py sqla20 syntax #6057 #6493

Merged
merged 1 commit into from Mar 14, 2024
Merged

Core & Internals: core/rule.py sqla20 syntax #6057 #6493

merged 1 commit into from Mar 14, 2024

Conversation

erlingstaff
Copy link
Contributor

@erlingstaff erlingstaff commented Feb 1, 2024 •
edited

PR submitted for only rule.py as this file contains ~1000 additions/deletions.

@erlingstaff erlingstaff marked this pull request as ready for review February 2, 2024 13:22
@dchristidis dchristidis mentioned this pull request Feb 19, 2024
Merged
bari12
bari12 reviewed Feb 20, 2024
View reviewed changes
lib/rucio/core/rule.py Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
@bari12 bari12 requested a review from rdimaio February 20, 2024 15:24
rdimaio
rdimaio reviewed Feb 21, 2024
View reviewed changes
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Show resolved Hide resolved
rdimaio
rdimaio reviewed Feb 21, 2024
View reviewed changes
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
rdimaio
rdimaio reviewed Feb 21, 2024
View reviewed changes
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
rdimaio
rdimaio previously approved these changes Mar 7, 2024
View reviewed changes
dchristidis
dchristidis requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! Most of my comments are of an aesthetic nature, but some are genuine issues and I’m concerned that our tests didn’t pick up on them.

lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
rdimaio
rdimaio reviewed Mar 11, 2024
View reviewed changes
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
@erlingstaff erlingstaff force-pushed the patch-6057-sqla20_syntax_core_rule branch from ca4e11c to 6791dff Compare March 11, 2024 19:34
dchristidis
dchristidis requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up nicely. Following my second full review, I am now more confident that the new queries are correct.

lib/rucio/core/rule.py Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
lib/rucio/core/rule.py Outdated Show resolved Hide resolved
@erlingstaff erlingstaff force-pushed the patch-6057-sqla20_syntax_core_rule branch from 8b77972 to 79db18d Compare March 14, 2024 10:03
dchristidis
dchristidis approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked a third full review, but I think it has been more than enough.

@bari12 bari12 merged commit 4ec8557 into rucio:master Mar 14, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bari12 bari12 bari12 left review comments

@rdimaio rdimaio rdimaio left review comments

@dchristidis dchristidis dchristidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlingstaff @bari12 @dchristidis @rdimaio