Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicas: Add type hints #6509

Merged
merged 1 commit into from Feb 27, 2024

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Feb 22, 2024

Part of #6454
Tests pass locally

Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s useful to prefix the commit message with a component. I would guess that Replicas: is the best match here? Otherwise the changes contained in the commit are perfect.

@rdimaio rdimaio force-pushed the patch-6454-type-annotation-quarantined branch from 116951c to 2b4b429 Compare February 22, 2024 15:07
@rdimaio rdimaio changed the title Add type hints Replicas: Add type hints Feb 22, 2024
dchristidis
dchristidis previously approved these changes Feb 22, 2024
@dchristidis dchristidis self-requested a review February 23, 2024 09:21
@rdimaio
Copy link
Contributor Author

rdimaio commented Feb 23, 2024

Test failure seems unrelated:

 tests/test_judge_evaluator.py:520: in test_judge_double_container_with_existing_rule
    assert not get_replica_locks(**F)
E   AssertionError: assert not [<rucio.db.sqla.models.ReplicaLock object at 0x7f7caf7dc460>]
E    +  where [<rucio.db.sqla.models.ReplicaLock object at 0x7f7caf7dc460>] = get_replica_locks(**{'name': '/belle/HCXHHT-judge_evaluator-judge_double_container_with_existing_rule-/cont_e77000060ac143ce88854e57b3cc4844/dataset_4d975954d5d4492c9821573cb9fe46bd/file_a92a8acd339444c3a7bc2a91730587ec', 'scope': mock})

re-running

@bari12 bari12 merged commit 788a0d4 into rucio:master Feb 27, 2024
44 checks passed
@bari12 bari12 linked an issue Feb 27, 2024 that may be closed by this pull request
@rdimaio rdimaio deleted the patch-6454-type-annotation-quarantined branch February 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotate the code
3 participants