Auth: Remove support for wildcard audiences #6524 #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects third-party-copy transfers and deletions. The following
configuration options are removed:
[conveyor]
request_oidc_audience = ...
[reaper]
oidc_audience = ...
They were part of the original token implementation and were kept as a
contingency option for the Data Challenge 2024. However, they should
not be used due to security concerns.
Wildcard audiences can make tokens less secure than X.509 certificates.
For one thing, an unintentional token leak is more likely to happen
(e.g. debugging logs). For another, the token is fully transferred to
the storages; a compromised site could be used as a vector to affect
data at other sites.
Moving forward, Rucio communities which use tokens must coordinate with
their sites to ensure that the storages properly identify themselves as
the intended recipient of a token (using the domains of the RSE
protocols in the audience claim).
dchristidis
force-pushed
the
feature-6524-Auth__Remove_support_for_wildcard_audiences
branch
from
7f0fa8f
to
a2f5838
Compare
rdimaio
approved these changes
Mar 7, 2024
dchristidis
deleted the
feature-6524-Auth__Remove_support_for_wildcard_audiences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects third-party-copy transfers and deletions. The following configuration options are removed:
They were part of the original token implementation and were kept as a contingency option for the Data Challenge 2024. However, they should not be used due to security concerns.
Wildcard audiences can make tokens less secure than X.509 certificates. For one thing, an unintentional token leak is more likely to happen (e.g. debugging logs). For another, the token is fully transferred to the storages; a compromised site could be used as a vector to affect data at other sites.
Moving forward, Rucio communities which use tokens must coordinate with their sites to ensure that the storages properly identify themselves as the intended recipient of a token (using the domains of the RSE protocols in the audience claim).