Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing: Add type annotations to vo.py #6549

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Mar 12, 2024

#6454

On the # type: ignore change: the error log ignored by this message is this one:

Found 1 new problems in /home/runner/work/rucio/rucio/lib/rucio/daemons/automatix/automatix.py
  - 1 errors with message """Argument of type "Unknown | str | None" cannot be assigned to parameter "vo" of type "str" in function "map_vo"
                               Type "Unknown | str | None" cannot be assigned to type "str"
                                 "None" is incompatible with "str"""".
    Candidates: line 169

I tried a few fixes, but the issue is that that portion of code assumes that client.vo is not None, even though it might be. A functional change needs to be done to fix that logic. We can do this at a later point, when handling the # type: ignore comments.

@rdimaio rdimaio marked this pull request as ready for review March 12, 2024 18:13
@bari12 bari12 requested a review from dchristidis March 20, 2024 15:36
@bari12 bari12 merged commit ecf37f7 into rucio:master Apr 8, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants