Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and fixing type annotations in rule.py #6556

Merged
merged 4 commits into from Mar 14, 2024
Merged

Refactoring and fixing type annotations in rule.py #6556

merged 4 commits into from Mar 14, 2024

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Mar 13, 2024

Addressing changes raised here #6516

#6454

dchristidis
dchristidis previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under different circumstances I would have requested further changes. However, given the urgency to prepare the next release candidate, I believe it’s fine to merge it in its current state.

lib/rucio/core/rule.py Outdated Show resolved Hide resolved
@rdimaio
Copy link
Contributor Author

rdimaio commented Mar 13, 2024

Re-formatted to follow style outlined here #6516 (comment)

@bari12 bari12 linked an issue Mar 14, 2024 that may be closed by this pull request
Type annotate the code #6454
Closed
@bari12 bari12 merged commit b814e6a into rucio:master Mar 14, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchristidis dchristidis dchristidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type annotate the code
3 participants
@rdimaio @dchristidis @bari12