Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfers: metrics API endpoint, allow to group RSEs by attribute in response #6567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Mar 14, 2024

Usage: requests/metrics?group_response_by=[attr]

Note: I didn't test this as I am not yet sure how to test API requests. I would appreciate some guidance on this if possible.

Fix #6564

Copy link
Contributor

@dchristidis dchristidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m concerned that the name group_response_by and the documentation around it can be misleading or not intuitive. I would be more precise that this is about RSE attributes.

Also, links should not be silently omitted if the RSE attribute does not exist (maybe use something like rse.attributes.get(key, 'UNKNOWN') instead ?)

@rdimaio
Copy link
Contributor Author

rdimaio commented Mar 19, 2024

I’m concerned that the name group_response_by and the documentation around it can be misleading or not intuitive. I would be more precise that this is about RSE attributes.

Also, links should not be silently omitted if the RSE attribute does not exist (maybe use something like rse.attributes.get(key, 'UNKNOWN') instead ?)

@dchristidis thanks for the comments. Would group_response_by_rse_attribute be an acceptable name or do you have other suggestions?

@dchristidis
Copy link
Contributor

The presence of ‘response’ feels unnecessary. Maybe group_by_attribute or group_by_rse_attribute?

@rdimaio
Copy link
Contributor Author

rdimaio commented Mar 20, 2024

Please ignore the changes in test_request.py that I accidentally added in the first force-push; I reverted them in the second force-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics API endpoint: allow option to return RSEs identified by RSE attribute
2 participants