Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core & Internals: Regression fix for judge #6569 #6570

Merged
merged 1 commit into from Mar 15, 2024
Merged

Core & Internals: Regression fix for judge #6569 #6570

merged 1 commit into from Mar 15, 2024

Conversation

erlingstaff
Copy link
Contributor

@erlingstaff erlingstaff commented Mar 15, 2024 •
edited

Missing session.execute was causing the judge evaluator to crash. Tested in the docker-compose stack with:

tools/run_tests.sh -ir
rucio add-dataset test:mynewdataset
rucio attach test:mynewdataset test:file1 test:file2 test:file3 test:file4
rucio add-rule test:mynewdataset 1 XRD3
rucio-judge-evaluator --run-once

This procedure fails without these changes, and does not with them.
Additionally, I looked through rule.py for similar errors, but did not find any

@erlingstaff erlingstaff marked this pull request as ready for review March 15, 2024 09:07
@bari12 bari12 merged commit 7537063 into rucio:master Mar 15, 2024
27 of 28 checks passed
@dchristidis dchristidis linked an issue Mar 15, 2024 that may be closed by this pull request
Regression from #6493 #6569
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimaio rdimaio rdimaio approved these changes

@dchristidis dchristidis Awaiting requested review from dchristidis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression from #6493
3 participants
@erlingstaff @rdimaio @bari12