Testing: sort imports and add isort-only Ruff to pre-commit and autotests #6578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimaio
force-pushed
the
patch-6538-sorting
branch
from
b1debb9
to
0f0aef3
Compare
|
latest force-push is just a rebase from master and a fix to the merge conflict (correctly ordered the out-of-order imports from #6579) |
rdimaio
force-pushed
the
patch-6538-sorting
branch
2 times, most recently
from
0f0aef3
to
79bd1fa
Compare
|
latest force-push is just a rebase from master and a fix to the merge conflict (correctly ordered the out-of-order imports from the last commits merged) |
Adding Ruff to both the pre-commit script (with --fix passed, thus sorting imports automatically) and to GH autotest (checking only). Ruff is currently only configured to check for import sorting. Other linting functions (flake8, pyupgrade) will be added progressively.
rdimaio
force-pushed
the
patch-6538-sorting
branch
from
79bd1fa
to
af3f2a0
Compare
bari12
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6538