Recovery: Fix crash of the replica recoverer when adding rules #6597 #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimaio
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Instead of catching every exception, I think it's best if we specifically catch DuplicateRule, as that's the only kind of crash we identified so far. We can also have a generic catch-all exception block afterwards, to avoid crashing in case of other exceptions.
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py
Outdated
Show resolved
Hide resolved
ChristophAmes
force-pushed
the
patch-6597-Crash_of_the_replica_recoverer_when_adding_rules
branch
2 times, most recently
from
fb221fb
to
7f19be7
Compare
ChristophAmes
force-pushed
the
patch-6597-Crash_of_the_replica_recoverer_when_adding_rules
branch
from
7f19be7
to
54c0ede
Compare
rdimaio
approved these changes
Mar 26, 2024
bari12
pushed a commit
that referenced
this pull request
Apr 2, 2024
voetberg
pushed a commit
to voetberg/rucio
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The replica-recoverer sometimes crashes if it tries to add a rule that already exists.
A protection needs to be added here : https://github.com/rucio/rucio/blob/master/lib/rucio/daemons/replicarecoverer/suspicious_replica_recoverer.py#L363
Steps to reproduce
Rucio Version
No response
Additional Information
No response