Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add type annotations to config.py #6609

Merged
merged 1 commit into from Apr 18, 2024

Conversation

rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Mar 27, 2024

@rdimaio
Copy link
Contributor Author

rdimaio commented Mar 27, 2024

Regarding the Pyright failure:

Found 5 new problems in /home/runner/work/rucio/rucio/lib/rucio/core/credential.py
  - 5 errors with message """Object of type "None" is not subscriptable""".
    Candidates: line 152, 153, 154, 155, 199

I think this can be ignored - this issue existed prior to the type annotations change, and it's due to the fact that cred might not exist when it's accessed in those lines in credential.py (as get_rse_credentials might raise ErrorLoadingCredentials. credential.py has to check that cred exists first.

@bari12 bari12 merged commit c81ab98 into rucio:master Apr 18, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants