Testing: Check variables exist before accessing them, and add type annotations to common/pcache #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimaio
commented
Apr 22, 2024
| @@ -1072,7 +1095,7 @@ def do_http_post(self, url, data): | |||
| # This will retry for up to 1 hour, at 2 minute intervals | |||
| while retry < 30: | |||
| try: | |||
| u = urlopen(url, data=urlencode(data)) | |||
| u = urlopen(url, data=urlencode(data)) # type: ignore | |||
There was a problem hiding this comment.
This type: ignore is due to the fact that the type returned by urlencode is not compatible with the type accepted by data in urlopen.
I'm not sure how this actually behaves at runtime, but due to the type mismatch I'm assuming that urlencode shouldn't be used in this context. I think it's best to address this separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6588.