Testing: Add type annotations to core/did #6732
Conversation
| def __add_files_to_archive(parent_did, files_temp_table, files, account, ignore_duplicate=False, *, session: "Session"): | ||
| def __add_files_to_archive( | ||
| parent_did: models.DataIdentifier, | ||
| files_temp_table: Any, |
There was a problem hiding this comment.
Note on the type Any for the temp tables across these functions:
These temp tables are generated via rucio.db.sqla.util._create_temp_table, which returns the class DeclarativeObj, which is defined inside _create_temp_table itself.
Refactoring this class to be defined outside of _create_temp_table does not seem to be straightforward, as the class definition itself uses variables from _create_temp_table. These could be set in a constructor, but I'm not sure if the functionality would remain the same.
A workaround would be to create a TypeVar named DeclarativeObj to annotate these tables more specifically, but then type checkers complain that TypeVar[DeclarativeObj has no members scope and name.
The solution would be to refactor DeclarativeObj out of _create_temp_table, but I would like to do this in a follow-up PR with assistance from someone that has already worked closely on these methods.
Part of #6588