Set use_built_in_shell_environment default to True #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for a protoc compiled with MinGW, which has a dependency on C:\msys64\mingw64\bin\libstdc++-6.dll and thus requires C:\msys64\mingw64\bin to be in the PATH.
|
I’m tracking your conversation at grpc/grpc-java#8984 to see where the consensus is on this flag. I thought it used to be that it was not recommended, but perhaps that’s changed or perhaps I misremember. |
|
The same change was merged by grpc-java here: grpc/grpc-java#8984 I've also filed an issue upstream about the underlying problem of |
Merged
|
Merging into dev for inclusion to #178. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for a protoc compiled with MinGW, which has a dependency on
C:\msys64\mingw64\bin\libstdc++-6.dlland thus requiresC:\msys64\mingw64\binto be in the PATH.Fixes #181