Implement BaseFilesystemReader in S3Reader and SharePoint Reader #13408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
2 tasks
Javtor
changed the title
|
@Javtor you can update the base branch to be |
…rface-simpledirreader
…/fs-reader-interface
dosubot
bot
added
size:XL
Javtor
changed the base branch from
main
to
javier/fs-reader-interface-simpledirreader
dosubot
bot
added
size:L
logan-markewich
approved these changes
May 16, 2024
There was a problem hiding this comment.
This seems like a good start to implementing this, thanks @Javtor (also yay tests)
| from llama_index.core.readers.base import BaseReader, BasePydanticReader | ||
| from llama_index.core.schema import Document | ||
| from llama_index.core.bridge.pydantic import Field | ||
|
|
||
|
|
||
| class S3Reader(BasePydanticReader): | ||
| class S3Reader(BasePydanticReader, BaseFilesystemReader): |
There was a problem hiding this comment.
I almost wonder if BaseFileSystemReader should just be subclassing BasePydanticReader? If we follow the dependency list of classes, now S3Reader inherits both BaseReader and BasePydanticReader lol
(This is where all the subclasses start to get confusing haha)
There was a problem hiding this comment.
agreed, this multiple inheritance is confusing.
…rface-simpledirreader
…/fs-reader-interface
Base automatically changed from
javier/fs-reader-interface-simpledirreader
to
main
May 17, 2024 17:15
dosubot
bot
added
size:XL
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
BaseFilesystemReaderinterface to be able to break down the process of reading files from a file system in two separate steps: first listing the files and then reading each individual file. Additionally, add a method to be able to read the info for a file without needing to actually get the file content from the filesystem.Depends on #13424 being merged first, because the changes done to integrations here (like S3 and SharePoint) depend on the core package version being bumped first to pass CI.
Version Bump?
Type of Change
How Has This Been Tested?