feat: do not react with emoji if "EmojiReaction" flag is empty #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/CaioAugustoo/atlantis into feat/disable-emoji-reaction-flag
…le-emoji-reaction"
CaioAugustoo
requested review from
lkysow,
lukemassa and
nitrocode
and removed request for
a team
github-actions
bot
added
docs
CaioAugustoo
changed the title
|
Hi, @CaioAugustoo, why do we not make The whole idea about my comment is that the flag should always be disabled by default. |
CaioAugustoo
changed the title
@jamengual, Done! I made some changes. Let me know if it makes sense for you! |
…/CaioAugustoo/atlantis into feat/disable-emoji-reaction-flag
jamengual
previously approved these changes
Apr 2, 2024
jamengual
added
refactoring
|
Thank you @jamengual! |
…ble-emoji-reaction-flag
chenrui333
approved these changes
May 21, 2024
chenrui333
requested review from
a team and
GenPage
and removed request for
a team
|
not quite sure why e2e tests run on the merge commit |
|
Thanks @CaioAugustoo for your first contribution to atlantis! 💯 |
1 task
ragne
pushed a commit
to ragne/atlantis
that referenced
this pull request
May 23, 2024
…lantis#4378) Co-authored-by: caio.rocha <caio.rocha@ifood.com.br> Co-authored-by: PePe Amengual <jose.amengual@gmail.com> Co-authored-by: Rui Chen <rui@chenrui.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
According to #3360: "setting the emoji-reaction property to an empty string should disable comment reactions. This is not working, and the default eyes emoji continues to be used."
Also, as @jamengual mentioned: "It sounds weird to me that we will add another config flag to disable the emojis, I think this logic needs to be fixed. it should be disabled by default like all the other flags"
This PR makes "EmojiReaction" flag default value to an empty string. In case "EmojiReaction" flag is empty no comment will be reacted.
tests
make testmake buildreferences
emoji-reactionto an Empty String does not Disable Comment Reactions #3457