fix: renovate dockerfile handling #4381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagomeireles
requested review from
jamengual,
lukemassa and
nitrocode
and removed request for
a team
tiagomeireles
changed the title
jamengual
reviewed
Apr 2, 2024
| @@ -6,7 +6,7 @@ ARG GOLANG_VERSION=1.22.1 | |||
|
|
|||
| # renovate: datasource=github-releases depName=hashicorp/terraform versioning=hashicorp | |||
| ARG DEFAULT_TERRAFORM_VERSION=1.7.2 | |||
| # renovate: datasource=github-releases depName=hashicorp/terraform versioning=hashicorp | |||
| # renovate: datasource=github-releases depName=opentofu/opentofu versioning=hashicorp | |||
There was a problem hiding this comment.
is versioning=hashicorp for opentofu?
There was a problem hiding this comment.
Yes, I believe so.
|
Hi tiago. Thanks for this pr. Could you resolve the conflicts? Also could you link to your fork's renovate page where it shows the additional dependencies screenshot above? |
|
I don't want to steal Tiagos contribution, but would like to see this progress. |
|
Thanks @tiagomeireles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The Dockerfile defines default versions of terraform, opentofu and conftest in
ARG's. Renovate will now update these.This also corrects the renovate configuration for opentofu.
why
This broke in 6d3aef2 when it switched the defines from
ENVs toARGs.tests
Manually tested on my fork of Atlantis.
references